Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lab goal
Prototype the remaining scroll failure from e2e-inc#775 without adding a CSS/layout heuristic to the decision executor.
The live benchmark on e2e-inc#775 showed that the fingerprint fix recovers viewport scrolling, but nested-scroll scenarios still fail because the executor can only call:
even though the runner already supports:
The missing fact is which observed nodes are actually scroll surfaces.
Invariant
The executor should choose among scroll targets the engine has evidence for; it should never guess scrollability from a role, size, or DOM shape.
This branch adds an additive semantic state:
isScrollableNodeLikeclassification;scroll_up/scroll_downkeep the viewport as a candidate and add visible engine-proven scroll containers. With more than one candidate, the decision request asks a target question and dispatches the selected existingctx.actions.scroll(direction, target).No coordinates or node ids become durable authority; the target remains an id from the newest observation and the runner owns stale-ref handling.
Why separate from e2e-inc#775
e2e-inc#775 is already close to merge, and @guhcostan correctly identified nested scrolling as a design decision rather than something to slip into its stall-guard fix. This branch is intentionally a delta from e2e-inc#775 head
a1c14b75so the seam can be reviewed independently.Coverage
scroll_down_targetand dispatches the chosen node;overflow: hiddenand content that fits;scrollable.Credit
This follows the live diagnosis from @okwasniewski and @guhcostan on e2e-inc#775. The existing targeted
ExecutorActions.scroll(direction, target?)API does the actual work; this branch only exposes the missing platform evidence to the executor.Verification
Not run in this GitHub connector environment. Before proposing upstream, run:
Then rerun the e2e-inc#775 live benchmark cases:
infinite-scroll,virtualized-table, andsticky-chrome, and compare target choices / completion rate againsta1c14b75.