Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing upstream work
Target: tester-army/e2e#1209 by knowbody. This fork draft uses exact origin head
efa739b1889028853ec44ead5929bdecd711f246as its base. It addresses concrete requests from maintainer okwasniewski's follow-up review. It is not another origin PR.Changes
revokeReuse()sends the final-shutdown message without restarting its existing kill deadline. The existing scheduler tests assertpreserveResources: truefollowed by a finalshutdown, including forced termination of a still-live retired worker.canKeepSessionwithout changing its predicate.device.closeAppand in the mobile changeset: a leftover native recording forces a session close at the next attempt, dropping the leased session's claim.Evidence / next gate
scheduler.test.tscases for final-drain revocation and force-revocation, and verified exact unchanged IPC message semantics.pnpm check, relevant unit suites and native device runs not executed locally in this constrained workspace; wait for CI/maintainer review before promotion.Credit: original contribution knowbody, architecture/review okwasniewski, additional inline issue report Cubic. This small fork draft is a cherry-pick/review aid only. Do not edit the author's upstream branch without consent, auto-approve, or merge.
Coordination: #12