Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Target
Follow-up to original author kuishou68's tester-army/e2e#958, using its exact head
d310846848068b2e82a96d192b6a826f5a563447as this fork draft PR's base. The latest Cubic review identified delayed uploads after cancellation: e2e-inc#958 (comment) and e2e-inc#958 (comment) .Fix
The outer guard can abandon a
filechooserwait when the operation is cancelled or times out. If the chooser event arrives later, the olduploadFilescontinuation can still callsetFiles. That can mutate the page after the step has ended.connectionAborterror mapping and checkoperation.signalbefore directsetInputFiles, before triggering the chooser click, and after awaiting the chooser before dispatchingsetFiles.Evidence
pnpm check, native Chromium and unit test suite not run in this execution environment (unavailable pnpm dependencies/network). Needs CI before promotion.ConnectionBudget.signalfrom the outer operation in all engines.Do not promote as a new competing origin PR; review/cherry-pick into e2e-inc#958. Original solution and tests by kuishou68; maintainer okwasniewski rewrote the upload flow; Cubic identified this follow-up race. Credit retained.
Coordination: #12