Skip to content

fix(web): do not retry a detached action after its input dispatched - #13

Draft
kvnloo wants to merge 3 commits into
review/805-basefrom
review/805-post-dispatch-detach-guard
Draft

kvnloo wants to merge 3 commits into
review/805-basefrom
review/805-post-dispatch-detach-guard

Conversation

@kvnloo

@kvnloo kvnloo commented Oct 17, 2026

Copy link
Copy Markdown
Owner

Context

Small, isolated follow-up on e2e-inc#805 by original author okwasniewski. This draft is based on exact upstream PR head dc80df2424294f3514ef8a1c1f6e2ee04db1b119, not the fork's older main. It addresses the most recent maintainer review: e2e-inc#805 (review) .

Playwright may log a pre-dispatch element detach, retry internally, then dispatch elementHandle.press("Enter") on the next pass before timing out waiting for navigation. The current classifier sees the earlier detach first and incorrectly produces retryable NODE_STALE; replay may submit again.

Change

  • A detached action with a later whole-line post-dispatch marker is ACTION_MAY_HAVE_COMMITTED (non-retryable), even if the log also mentions a prior detach.
  • A detach with no dispatch evidence remains NODE_STALE.
  • Regression fixture preserves both the positive and negative classifications.

Verified

  • Github compare shows 2 files, +34 lines, 0 removals against exact PR feat(cache): fallback relocation ladder and recorded replay pacing e2e-inc/e2e#805 head.
  • Regression asserts output codes for detached→press and detached-only Playwright call logs.
  • Full pnpm check / pnpm test (not run: current execution sandbox has no network access or installed e2e monorepo dependencies). Do not claim green until CI runs.
  • Native Chromium integration reproducer (not run).

This fork PR is for review/cherry-pick into existing upstream PR e2e-inc#805, not a competing origin PR. No automatic approval or origin merge. Original code/replay work and bug diagnosis credited to okwasniewski and the maintainer review thread; this patch is the guarded repair.

Coordination: #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant