Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Small, isolated follow-up on e2e-inc#805 by original author okwasniewski. This draft is based on exact upstream PR head
dc80df2424294f3514ef8a1c1f6e2ee04db1b119, not the fork's oldermain. It addresses the most recent maintainer review: e2e-inc#805 (review) .Playwright may log a pre-dispatch element detach, retry internally, then dispatch
elementHandle.press("Enter")on the next pass before timing out waiting for navigation. The current classifier sees the earlier detach first and incorrectly produces retryableNODE_STALE; replay may submit again.Change
ACTION_MAY_HAVE_COMMITTED(non-retryable), even if the log also mentions a prior detach.NODE_STALE.Verified
pnpm check/pnpm test(not run: current execution sandbox has no network access or installed e2e monorepo dependencies). Do not claim green until CI runs.This fork PR is for review/cherry-pick into existing upstream PR e2e-inc#805, not a competing origin PR. No automatic approval or origin merge. Original code/replay work and bug diagnosis credited to okwasniewski and the maintainer review thread; this patch is the guarded repair.
Coordination: #12