HYPERFLEET-1282: Document pageSize→size / orderBy→order breaking change#2
Closed
kuudori wants to merge 1 commit into
Closed
HYPERFLEET-1282: Document pageSize→size / orderBy→order breaking change#2kuudori wants to merge 1 commit into
kuudori wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira
HYPERFLEET-1282 · Epic: HYPERFLEET-1272
What
Adds breaking-change checklist entry openshift-hyperfleet#5 for the pagination query parameter rename (
pageSize→size,orderBy→order) introduced in HYPERFLEET-1272 and implemented in hyperfleet-api PR #253.Also updates two stale
pageSize=10benchmark labels inperformance-baselines.md.AC → coverage
hyperfleet/docs/release/v1.0.0/breaking-changes.mdpageSize→size,orderBy→orderChanges
hyperfleet/docs/release/v1.0.0/breaking-changes.md— insert row chore : update readme to capture more details of the repo openshift-hyperfleet/architecture#5 (pagination rename) in API Contract table; renumber downstream rows chore : update readme to capture more details of the repo openshift-hyperfleet/architecture#5-17 → DO NOT MERGE ; Example status swagger openshift-hyperfleet/architecture#6-18 (one inline#9ref updated to#10)hyperfleet/docs/performance-baselines.md— update two benchmark labelspageSize=10→size=10Verification
pkg/services/types.goin hyperfleet-api PR #253 (merged) reads onlyparams.Get("size")/params.Get("order"); old names silently fall to defaults (page=1, size=20, no ordering)npx markdownlint-cli2: 0 errorsc13125f(main, up to date)E2E
Gated in CI, not run locally (documentation-only change).