Invert color-mode toggle icon to show the target mode#7
Merged
Conversation
Eject ColorModeToggle from theme-classic so the navbar icon shows the mode you would switch to (moon on a light background, sun on a dark background) instead of the current mode. The component logic is identical to upstream; only the co-located styles.module.css swaps the light/dark display mapping. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The navbar theme toggle showed the icon of the current mode (light -> sun, dark -> moon). This inverts it so the icon shows the mode you would switch to: moon on a light background, sun on a dark background.
Ejects
ColorModeTogglefrom@docusaurus/theme-classic. The.tsxis byte-identical to upstream (low upgrade-maintenance); only the co-locatedstyles.module.cssswaps the light/dark display mapping. The system-mode icon is unchanged, and the button title/aria-label still announce the current mode.Verified in the dev server (moon on light, sun on dark) and
npm run buildpasses.Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com