Repository navigation
test(reporting): drop redundant function-level re import - #295
Merged
Merged
Conversation
re is already imported at module level (line 7); the local import inside test_html_labels_non_negative_with_monotonic_start shadowed it for no effect. Clears CodeQL py/repeated-import alert #125. Signed-off-by: kurok <22548029+kurok@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes a redundant
import reinside a test method.reis already imported at module level, so the local import did nothing. Clears CodeQL alert #125 (py/repeated-import).Changes
tests/test_reporting.py: remove the function-levelimport reinTestRpsTimelineRendering.test_html_labels_non_negative_with_monotonic_start; the test now uses the module-level import from line 7.Related Issues
Code-scanning alert #125.
Testing
pytest):tests/test_reporting.py58 passedruff check src/ tests/)Checklist