Repository navigation
test(distributed): a worker that has not reported yet is not reporting - #293
Merged
Merged
Conversation
test_the_master_streams_the_cluster_during_the_run asserted that every interval snapshot counted both workers. The first snapshot can legitimately land before a worker has sent its first progress message, and macos-latest 3.13 produced exactly that -- workers 1, then 2, 2, 2 -- so a correct cluster view failed the build. The claim worth making is that the view converges: at most two workers are ever counted, the last interval has both, and so does the final snapshot. Ramp-up is not a defect. Signed-off-by: Yurii Riabikov <22548029+kurok@users.noreply.github.com> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fourth CI flake this session. It turned PR #291 red on macos-latest 3.13.
Root cause
test_the_master_streams_the_cluster_during_the_runasserted:The first interval snapshot can legitimately land before a worker has sent its first progress message. macos-latest 3.13 produced exactly that:
That is a correct cluster view during ramp-up — a worker that has not reported yet is not reporting — and the assertion called it a failure.
The fix
Assert what is actually true: the view converges.
The point of the original assertion — that the master merges both workers rather than one — is preserved by the last two checks. Ramp-up is not a defect.
Unrelated to #291's change: the
workers_reportedtags added there go on the end-of-run report config, while this count comes from the progress aggregator. #291 only shifted the timing that exposed it.Checks
ruff format/check clean,
1920 passed. Ran the test twice locally.