Add support for extracting paths from markdown comments and rename offset methods#44
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the tree-sitter-based path extraction pipeline to also find paths written using Markdown syntax inside comments (e.g., markdown links and inline code in //, /* */, doc comments, and HTML comments), and renames the document offset-to-position helper to explicitly reflect byte-based positioning.
Changes:
- Add per-language comment-range extraction helpers (markdown/mdx, html, dockerfile, and a general extractor for several languages).
- Update path extraction to re-parse comment ranges as Markdown and merge those candidates with existing string-literal candidates.
- Rename
offset_to_utf8_pos→offset_to_byte_posand adjust tests/docs/changelog accordingly.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/parser/tree_sitter/ts_markdown.rs | Adds detection of HTML comment node ranges in markdown/mdx trees. |
| src/parser/tree_sitter/ts_html.rs | Adds HTML comment range collection for subsequent markdown re-parse. |
| src/parser/tree_sitter/ts_general.rs | Adds comment range collection across multiple languages (incl. Rust-specific comment node kinds). |
| src/parser/tree_sitter/ts_dockerfile.rs | Adds Dockerfile comment range collection for markdown re-parse. |
| src/parser/tree_sitter/mod.rs | Integrates comment-range extraction + markdown re-parse into the main extraction flow; updates/extends tests. |
| src/document/mod.rs | Renames and simplifies offset→(row,col) conversion to byte terminology. |
| README.md | Updates roadmap/status entry to reflect the new comment-markdown extraction capability. |
| CHANGELOG.md | Records the new core capability in the changelog. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.