Skip to content

DataTree initial work#73

Closed
kunitoki wants to merge 25 commits intomainfrom
dev/data_tree
Closed

DataTree initial work#73
kunitoki wants to merge 25 commits intomainfrom
dev/data_tree

Conversation

@kunitoki
Copy link
Copy Markdown
Owner

@kunitoki kunitoki commented Aug 25, 2025

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 25, 2025

Codecov Report

❌ Patch coverage is 73.39145% with 641 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.60%. Comparing base (a5991c6) to head (5fbf7e4).

Files with missing lines Patch % Lines
modules/yup_data_model/tree/yup_DataTree.cpp 64.56% 332 Missing ⚠️
modules/yup_data_model/tree/yup_DataTreeQuery.cpp 68.87% 235 Missing ⚠️
modules/yup_data_model/tree/yup_DataTreeSchema.cpp 90.79% 30 Missing ⚠️
...odules/yup_data_model/tree/yup_AtomicCachedValue.h 80.24% 16 Missing ⚠️
...dules/yup_data_model/tree/yup_DataTreeObjectList.h 87.32% 9 Missing ⚠️
modules/yup_data_model/tree/yup_DataTree.h 87.30% 8 Missing ⚠️
modules/yup_data_model/tree/yup_CachedValue.h 93.51% 7 Missing ⚠️
modules/yup_data_model/tree/yup_DataTreeQuery.h 93.33% 3 Missing ⚠️
modules/yup_data_model/tree/yup_DataTreeSchema.h 90.90% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   56.54%   57.60%   +1.06%     
==========================================
  Files         471      480       +9     
  Lines       47091    49527    +2436     
==========================================
+ Hits        26627    28532    +1905     
- Misses      20464    20995     +531     
Files with missing lines Coverage Δ
modules/yup_core/containers/yup_DynamicObject.cpp 100.00% <100.00%> (ø)
modules/yup_core/containers/yup_DynamicObject.h 66.66% <ø> (ø)
modules/yup_core/containers/yup_HashMap.h 98.37% <100.00%> (+0.30%) ⬆️
modules/yup_data_model/tree/yup_DataTreeSchema.h 90.90% <90.90%> (ø)
modules/yup_data_model/tree/yup_DataTreeQuery.h 93.33% <93.33%> (ø)
modules/yup_data_model/tree/yup_CachedValue.h 93.51% <93.51%> (ø)
modules/yup_data_model/tree/yup_DataTree.h 87.30% <87.30%> (ø)
...dules/yup_data_model/tree/yup_DataTreeObjectList.h 87.32% <87.32%> (ø)
...odules/yup_data_model/tree/yup_AtomicCachedValue.h 80.24% <80.24%> (ø)
modules/yup_data_model/tree/yup_DataTreeSchema.cpp 90.79% <90.79%> (ø)
... and 2 more

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5991c6...5fbf7e4. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kunitoki kunitoki requested a review from Copilot August 25, 2025 21:55
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces the initial DataTree implementation for the YUP library, providing a hierarchical data model with transaction support, querying capabilities, and schema validation. The implementation includes comprehensive testing and covers multiple related components.

  • DataTree: Core hierarchical data structure with property management, child relationships, transaction support, and serialization
  • DataTreeSchema: Schema validation system for defining and validating DataTree structures with property constraints
  • DataTreeQuery: Fluent API for querying and filtering DataTree hierarchies with XPath support

Reviewed Changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/yup_data_model/yup_DataTreeSchema.cpp Comprehensive tests for schema validation, property constraints, and node creation
tests/yup_data_model/yup_DataTreeQuery.cpp Tests for fluent querying API, XPath support, and tree navigation
tests/yup_data_model/yup_DataTreeObjectList.cpp Tests for DataTree-backed object list management with automatic synchronization
tests/yup_data_model/yup_DataTree.cpp Core DataTree tests covering properties, children, transactions, and serialization
tests/yup_data_model/yup_CachedValue.cpp Tests for property caching system with automatic updates and type conversion
modules/yup_data_model/yup_data_model.h Updated module header to include new DataTree components
modules/yup_data_model/yup_data_model.cpp Updated module implementation to include new source files
modules/yup_data_model/tree/yup_DataTreeSchema.h Header file defining schema validation system for DataTree structures
Comments suppressed due to low confidence (1)

tests/yup_data_model/yup_DataTreeSchema.cpp:221

  • There is a typo in the transaction description. "ChildI nsertion At Index" should be "Child Insertion At Index" (missing space after "Child").
    // Test invalid node type

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@kunitoki kunitoki closed this Aug 26, 2025
@kunitoki kunitoki deleted the dev/data_tree branch August 26, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants