Skip to content

Midi keyboard component and more audio fun#70

Merged
kunitoki merged 13 commits intomainfrom
dev/midi_keyboard
Jul 21, 2025
Merged

Midi keyboard component and more audio fun#70
kunitoki merged 13 commits intomainfrom
dev/midi_keyboard

Conversation

@kunitoki
Copy link
Copy Markdown
Owner

image

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 16, 2025

Codecov Report

Attention: Patch coverage is 13.20755% with 46 lines in your changes missing coverage. Please review.

Project coverage is 57.46%. Comparing base (9daefef) to head (ca594f2).

Files with missing lines Patch % Lines
modules/yup_graphics/graphics/yup_Graphics.cpp 0.00% 36 Missing ⚠️
...ules/yup_gui/themes/theme_v1/yup_ThemeVersion1.cpp 30.76% 9 Missing ⚠️
...s/yup_python/bindings/yup_YupGraphics_bindings.cpp 75.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (13.20%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
- Coverage   57.52%   57.46%   -0.07%     
==========================================
  Files         428      428              
  Lines       43434    43480      +46     
==========================================
- Hits        24985    24984       -1     
- Misses      18449    18496      +47     
Files with missing lines Coverage Δ
modules/yup_graphics/graphics/yup_Color.h 92.65% <ø> (ø)
modules/yup_graphics/graphics/yup_ColorGradient.h 100.00% <ø> (ø)
modules/yup_graphics/graphics/yup_Graphics.h 86.20% <ø> (ø)
modules/yup_gui/widgets/yup_Label.cpp 56.14% <ø> (ø)
modules/yup_gui/widgets/yup_Label.h 33.33% <ø> (ø)
...s/yup_python/bindings/yup_YupGraphics_bindings.cpp 92.86% <75.00%> (-0.10%) ⬇️
...ules/yup_gui/themes/theme_v1/yup_ThemeVersion1.cpp 6.54% <30.76%> (+0.45%) ⬆️
modules/yup_graphics/graphics/yup_Graphics.cpp 62.85% <0.00%> (-5.78%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9daefef...ca594f2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kunitoki kunitoki merged commit d88244e into main Jul 21, 2025
@kunitoki kunitoki deleted the dev/midi_keyboard branch July 21, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants