Skip to content

Combo Box and Other Widgets#62

Merged
kunitoki merged 34 commits intodev/popup_menufrom
dev/combo_box
Jun 30, 2025
Merged

Combo Box and Other Widgets#62
kunitoki merged 34 commits intodev/popup_menufrom
dev/combo_box

Conversation

@kunitoki
Copy link
Copy Markdown
Owner

@kunitoki kunitoki commented Jun 26, 2025

image

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 26, 2025

Codecov Report

Attention: Patch coverage is 49.64158% with 281 lines in your changes missing coverage. Please review.

Project coverage is 43.88%. Comparing base (6c39595) to head (f8ed471).
Report is 44 commits behind head on dev/popup_menu.

Files with missing lines Patch % Lines
modules/yup_gui/widgets/yup_ComboBox.cpp 56.88% 72 Missing ⚠️
...ules/yup_gui/themes/theme_v1/yup_ThemeVersion1.cpp 5.33% 71 Missing ⚠️
modules/yup_gui/component/yup_Component.cpp 58.55% 46 Missing ⚠️
modules/yup_gui/buttons/yup_SwitchButton.cpp 65.75% 25 Missing ⚠️
modules/yup_gui/buttons/yup_ToggleButton.cpp 62.50% 18 Missing ⚠️
modules/yup_gui/native/yup_Windowing_sdl2.cpp 0.00% 17 Missing ⚠️
modules/yup_gui/menus/yup_PopupMenu.cpp 16.66% 10 Missing ⚠️
modules/yup_gui/artboard/yup_Artboard.cpp 0.00% 8 Missing ⚠️
modules/yup_graphics/graphics/yup_Graphics.cpp 0.00% 5 Missing ⚠️
modules/yup_gui/buttons/yup_ToggleButton.h 60.00% 2 Missing ⚠️
... and 4 more

❌ Your patch status has failed because the patch coverage (49.64%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           dev/popup_menu      #62      +/-   ##
==================================================
+ Coverage           40.89%   43.88%   +2.99%     
==================================================
  Files                 303      399      +96     
  Lines               30001    36078    +6077     
==================================================
+ Hits                12269    15834    +3565     
- Misses              17732    20244    +2512     
Files with missing lines Coverage Δ
modules/yup_core/containers/yup_Variant.cpp 80.21% <ø> (+0.46%) ⬆️
modules/yup_events/messages/yup_ApplicationBase.h 60.00% <ø> (+40.00%) ⬆️
modules/yup_graphics/graphics/yup_Graphics.h 86.20% <ø> (ø)
...ules/yup_graphics/primitives/yup_AffineTransform.h 96.55% <100.00%> (-1.57%) ⬇️
modules/yup_graphics/primitives/yup_Point.h 99.09% <100.00%> (+0.01%) ⬆️
modules/yup_graphics/primitives/yup_Rectangle.h 96.91% <100.00%> (-2.79%) ⬇️
modules/yup_graphics/primitives/yup_Size.h 100.00% <100.00%> (ø)
modules/yup_gui/buttons/yup_Button.cpp 18.51% <100.00%> (ø)
modules/yup_gui/buttons/yup_Button.h 0.00% <ø> (ø)
modules/yup_gui/buttons/yup_TextButton.cpp 85.71% <100.00%> (ø)
... and 22 more

... and 250 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 065da80...f8ed471. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kunitoki kunitoki changed the title Combo box Combo Box and Other Widgets Jun 30, 2025
@kunitoki kunitoki merged commit d087d55 into dev/popup_menu Jun 30, 2025
32 of 33 checks passed
@kunitoki kunitoki deleted the dev/combo_box branch June 30, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants