feat: add GitLab-aware forge bootstrap boundary - #1560
Open
CodeFunta wants to merge 12 commits into
Open
Conversation
10 tasks
CodeFunta
force-pushed
the
feat/gitlab-bootstrap-provider-boundary
branch
from
August 3, 2026 09:12
ee30b40 to
0afa277
Compare
CodeFunta
force-pushed
the
feat/gitlab-bootstrap-provider-boundary
branch
from
August 3, 2026 16:40
012c899 to
b51117f
Compare
5 tasks
CodeFunta
force-pushed
the
feat/gitlab-bootstrap-provider-boundary
branch
from
August 4, 2026 04:03
b51117f to
e03d829
Compare
Owner
|
Automated reminder: thanks for the PR! This branch currently has a merge conflict with the base branch. When you get a chance, please rebase onto (or merge) the latest base branch, resolve the conflict, and push. After that, checks will re-run and the PR will get looked at again. Noted for firstmate#1560 at |
CodeFunta
force-pushed
the
feat/gitlab-bootstrap-provider-boundary
branch
from
August 4, 2026 23:25
e03d829 to
b892fea
Compare
CodeFunta
force-pushed
the
feat/gitlab-bootstrap-provider-boundary
branch
from
August 5, 2026 08:34
b892fea to
1634739
Compare
This was referenced Aug 5, 2026
Owner
|
Automated reminder: thanks for the PR! This branch currently has a merge conflict with the base branch. When you get a chance, please rebase onto (or merge) the latest base branch, resolve the conflict, and push. After that, checks will re-run and the PR will get looked at again. Noted for firstmate#1560 at |
added 10 commits
August 7, 2026 15:35
Derive forge tools and auth checks from registered project remotes so GitLab-only homes do not require GitHub tooling. Keep unknown hosts fail-closed and scope self-managed GitLab through FM_GITLAB_HOSTS. Refs: kunchenguid#695
Keep the GitLab tool diagnostic explicit instead of using a single-item loop.
CodeFunta
force-pushed
the
feat/gitlab-bootstrap-provider-boundary
branch
from
August 7, 2026 12:48
1e36b59 to
3819f3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Continue PR #1560 for the GitLab bootstrap provider boundary. Preserve the existing implementation, update the feature branch onto the latest main branch, resolve only genuine merge conflicts, push the updated branch, and monitor the PR until merge.
What Changed
Risk Assessment
✅ Low: The provider-aware bootstrap change is bounded, fail-closed for unsupported remotes, and covered by executable behavior tests; the only identified issue is an unused helper that does not affect runtime behavior.
Testing
Ran the focused bootstrap behavior suite against the changed implementation; all provider-boundary scenarios and related bootstrap contracts passed. The suite produced reviewer-visible CLI test evidence, and the worktree remained clean. No UI surface exists for this change, so screenshots were not applicable.
Evidence: Focused bootstrap provider-boundary test results
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
bin/fm-bootstrap.sh- merge conflict rebasing onto origin/mainbin/fm-forge-lib.sh:147- The newly added fm_forge_require_cli function is never called; bootstrap independently derives and checks the same provider CLI requirements. Remove this dead helper or make bootstrap use it so the provider-boundary contract has one implementation.✅ **Test** - passed
✅ No issues found.
bash tests/fm-bootstrap.test.shEnd-to-end bootstrap scenarios covering GitLab-only, GitHub-only, unknown, HTTPS, SSH/scp-style, local, and upstream-only remotesProvider-specific CLI and authentication diagnostics, including GitLab host normalization andglabrequirementsBootstrap backend and dependency behavior using hermetic fake toolchains✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.