Repository navigation
fix(settings): indent the body under every settings heading - #1443
Merged
Merged
Conversation
Only the block headings (Voice notes, Model assignment, ...) indented their body, so item headings such as "Model" and "Language" sat in the same column as their radio buttons and it was hard to see where an item ended. One rule now: whatever follows a heading is indented one step, at every level. - SETTINGS_ITEM_BODY_CLASS (pl-4) in SettingsGroup.tsx - SettingSection always indents its summary, details and controls (previously only when it had an icon) - Hand-written item headings follow the same rule: Language, MCP servers, Voice notes (Model / Language / Vocabulary / Terms to hide), and the bulk regenerate card (Kinds / two model pickers) - Headings inside bordered cards stay as they are; the border already shows the extent Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Migration fixturesClick to expand migration results |
Contributor
Performance regressionClick to expand performance results |
Contributor
Bench delta
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In Settings, only the block headings (Voice notes, Model assignment, …) indented what came after them. Item headings such as Model and Language sat in the same column as their radio buttons, so it was hard to see where one item ended.
One rule now: whatever follows a heading is indented one step, at every level.
SETTINGS_ITEM_BODY_CLASS(pl-4) inSettingsGroup.tsx, one place for the valueSettingSectionalways indents its summary, details and controls (previously only when it had an icon)No data, schema or wording changes. Docs sync: not applicable (styling only).
Test plan
pnpm exec tsc -p tsconfig.json --noEmitpnpm vitest run(702 files / 9104 tests)pnpm run lint:depspnpm manual:checkpnpm buildOrganisms/SettingsModal: every heading in all 7 tabs measured in the DOM — body starts 16px right of the heading's left edge (icon included); only the bordered "Connection status" card is 0, as intendedMolecules/MeetingSettingsSection: Model / Language content indented🤖 Generated with Claude Code