Version Packages - #129
Merged
Merged
Version Packages#129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@kud/gh-cockpit@0.8.0
Minor Changes
8f92f1f: The PR row is a component now, and anything holding a
GHItemcan draw one.Until now the only way to render a pull request the way the inbox renders one was to be the inbox. The layout — the aligned health, turn and number cells, the give-up ladder that sheds author, then a label, then size, then threads, then the repo, then the age rather than flooring the title, the two-tier age, the label cell, the diff-size colouring — lived inside a 700-line
ItemRowininbox.tsx, reachable only throughApp. Any second surface wanting the same row had the choice of mounting the whole inbox or writing the ladder again, and a second copy of that arithmetic is a second place for a row to overflow its container, which Ink answers by compressing every flexible child until the list wraps into a column of fragments.PrRowis that branch, lifted whole and exported:item,active,loginand thecolsit may actually use. It holds no timers and reads no clock. Everything the inbox does to a row over time — the merge sparkle, the transit ramps, the one-shot arrival and departure frames, how long GONE is held — stays in the inbox and reaches the row as three props after the decisions are made:iconputs a caller's glyph in the health cell,motionsays whether the title is arriving, departing or struck off, andannouncementsare the solid pills the row ends on. That is the whole seam, and it is what lets the choreography stay in one place while the layout is shared.Two things moved with it.
truncateis its own module, since both row renderers measure against the same budget. The backdrop — theDimContextthat dims the list behind an overlay, itsTextwrapper andbackdropStyle— is its own module too, and that one is load-bearing: the context has to be a single instance, and two modules each callingcreateContextwould compile, render, and silently never dim. Both keep their existing addresses on@kud/gh-ink.One behaviour changed on the way. A row wearing GONE was charged two columns for its pill's caps but nothing for the word inside them, so its title was priced eight columns wider than the row it was about to draw — invisible at a normal width and an overflow at a narrow one. Announcements are now charged in full, the same as MERGED always was.
Patch Changes
@kud/gh-ink@0.61.0
Minor Changes
8f92f1f: The PR row is a component now, and anything holding a
GHItemcan draw one.Until now the only way to render a pull request the way the inbox renders one was to be the inbox. The layout — the aligned health, turn and number cells, the give-up ladder that sheds author, then a label, then size, then threads, then the repo, then the age rather than flooring the title, the two-tier age, the label cell, the diff-size colouring — lived inside a 700-line
ItemRowininbox.tsx, reachable only throughApp. Any second surface wanting the same row had the choice of mounting the whole inbox or writing the ladder again, and a second copy of that arithmetic is a second place for a row to overflow its container, which Ink answers by compressing every flexible child until the list wraps into a column of fragments.PrRowis that branch, lifted whole and exported:item,active,loginand thecolsit may actually use. It holds no timers and reads no clock. Everything the inbox does to a row over time — the merge sparkle, the transit ramps, the one-shot arrival and departure frames, how long GONE is held — stays in the inbox and reaches the row as three props after the decisions are made:iconputs a caller's glyph in the health cell,motionsays whether the title is arriving, departing or struck off, andannouncementsare the solid pills the row ends on. That is the whole seam, and it is what lets the choreography stay in one place while the layout is shared.Two things moved with it.
truncateis its own module, since both row renderers measure against the same budget. The backdrop — theDimContextthat dims the list behind an overlay, itsTextwrapper andbackdropStyle— is its own module too, and that one is load-bearing: the context has to be a single instance, and two modules each callingcreateContextwould compile, render, and silently never dim. Both keep their existing addresses on@kud/gh-ink.One behaviour changed on the way. A row wearing GONE was charged two columns for its pill's caps but nothing for the word inside them, so its title was priced eight columns wider than the row it was about to draw — invisible at a normal width and an overflow at a narrow one. Announcements are now charged in full, the same as MERGED always was.
@kud/gh-pr-comments@0.1.115
Patch Changes
@kud/gh-pr-health@0.1.115
Patch Changes