Make link checker resilient to transient external failures#89
Open
anisurrahman75 wants to merge 1 commit into
Open
Make link checker resilient to transient external failures#89anisurrahman75 wants to merge 1 commit into
anisurrahman75 wants to merge 1 commit into
Conversation
The lychee link checker intermittently failed on master with "Connection failed. Check network connectivity and firewall settings" against kubernetes.io URLs that are actually valid (HTTP 200). The runner was hitting external sites with no retries and high concurrency, triggering rate-limiting / connection refusals. Lower --max-concurrency to 4 and add --max-retries 6, --retry-wait-time 5 and --timeout 30 so transient failures are retried instead of failing the build. Signed-off-by: Anisur Rahman <anisur@appscode.com>
|
Visit the preview URL for this PR (updated for commit 7e26cc2): https://kubestash-qa--pr89-fix-flaky-link-check-glyc3s0d.web.app (expires Fri, 26 Jun 2026 06:31:15 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7765752f86b485f0f549c1d5d58c61af5e2ecd74 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Master CI intermittently failed on the
Check linksstep with:The reported URLs are actually valid (HTTP 200). The failing set rotated run-to-run and the same commits passed on re-run — classic transient flakiness.
kubernetes.iowas intermittently rate-limiting / refusing connections from the runner, which hit external sites at concurrency 10 with no retries.Fix
Tune the lychee invocation:
--max-concurrency10 → 4 (less aggressive, avoids rate-limit triggers)--max-retries 6— retry transient failures instead of failing the build--retry-wait-time 5— back off between retries--timeout 30— tolerate slow responsesVerified locally with lychee v0.24.2 and the new flags:
0 Errors.