Skip to content

fix(): Add Istio mTLS exclusion for application pods while communicating with NSM manager on port 5000 #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
greninja517 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(): Add Istio mTLS exclusion for application pods while communicating with NSM manager on port 5000 #445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions controllers/slice/app_pod.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,12 @@ func (r *SliceReconciler) labelAppPodWithNsmIp(ctx context.Context, slice *kubes
if labels == nil {
labels = make(map[string]string)
}

annotations := pod.GetAnnotations()
if annotations == nil {
annotations = make(map[string]string)
}

_, ok := labels[controllers.NSMIPLabelSelectorKey]
if !ok {
updateNeeded = true
Expand All @@ -218,14 +224,22 @@ func (r *SliceReconciler) labelAppPodWithNsmIp(ctx context.Context, slice *kubes
}
}

// Add Istio exclusion for NSM communication
expectedExcludePort := "5000"
if annotations["traffic.sidecar.istio.io/excludeOutboundPorts"] != expectedExcludePort {
updateNeeded = true
annotations["traffic.sidecar.istio.io/excludeOutboundPorts"] = expectedExcludePort
}

if updateNeeded {
pod.SetLabels(labels)
pod.SetAnnotations(annotations)
err := r.Update(ctx, &pod)
if err != nil {
log.Error(err, "Failed to update NSM IP label for app pod", "pod", pod.Name)
log.Error(err, "Failed to update NSM IP label and Istio annotations for app pod", "pod", pod.Name)
return err
}
debugLog.Info("App pod label added/updated", "pod", pod.Name, "nsmIP", podInSlice.NsmIP)
debugLog.Info("App pod label and Istio exclusion added/updated", "pod", pod.Name, "nsmIP", podInSlice.NsmIP)
}
}

Expand Down