Skip to content

pass component prerelease image tag to E2E tests#765

Open
bvolovat wants to merge 1 commit intomainfrom
fix/pass-component-image-tags-v2
Open

pass component prerelease image tag to E2E tests#765
bvolovat wants to merge 1 commit intomainfrom
fix/pass-component-image-tags-v2

Conversation

@bvolovat
Copy link
Copy Markdown
Contributor

@bvolovat bvolovat commented Mar 31, 2026

Summary

  • Pass the prerelease image tag via component_image_tags in the E2E dispatch payload (local workflow copy)
  • Same change as kubescape/workflows but for node-agent's local incluster-comp-pr-merged.yaml
  • Removes charts_name from dispatch (receiver defaults it) to stay within GitHub's 10 key limit on client_payload

How it works

The dispatch now includes component_image_tags=nodeAgent-tag=<prerelease-version>. The receiver forwards it to system tests which override the helm chart image tag.

Test plan

  • Merge armosec/shared-workflows companion PR first
  • Trigger a node-agent PR merge and verify E2E tests use the prerelease image

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Refined CI/CD workflow dispatch for test runs: removed a hard-coded chart identifier and added explicit component image tag information so automated tests receive built artifact details more reliably.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 31, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: af656feb-af33-4101-a006-f4ad5c36b660

📥 Commits

Reviewing files that changed from the base of the PR and between 6f15eff and 9a78548.

📒 Files selected for processing (1)
  • .github/workflows/incluster-comp-pr-merged.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/incluster-comp-pr-merged.yaml

📝 Walkthrough

Walkthrough

A GitHub Actions workflow dispatch payload was updated: client_payload[charts_name] was removed and client_payload[component_image_tags] was added, built from inputs.COMPONENT_NAME and needs.docker-build.outputs.IMAGE_TAG_PRERELEASE. client_payload[charts_repo] remains unchanged.

Changes

Cohort / File(s) Summary
Workflow Dispatch Payload
.github/workflows/incluster-comp-pr-merged.yaml
Removed client_payload[charts_name]; added client_payload[component_image_tags] set to <COMPONENT_NAME>-tag=<IMAGE_TAG_PRERELEASE> from inputs and Docker build output. client_payload[charts_repo] unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 I hopped through YAML, light and quick,
Removed an old field, added a tag so slick,
Component names tied to image lore,
Dispatches hum and tests explore,
A tiny change, a joyful click.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: passing component prerelease image tag to E2E tests, which aligns with the workflow payload modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/pass-component-image-tags-v2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Replace the hardcoded charts_name (already defaulted in the receiver)
with component_image_tags so system tests run against the actual
pre-release image instead of the default release.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: bvolovat <borisv@armosec.io>
@bvolovat bvolovat force-pushed the fix/pass-component-image-tags-v2 branch from 6f15eff to 9a78548 Compare April 5, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants