Skip to content

Add tests for extractGitHubRepo, isAllDigits and splitCyclesByTestStatus - #105

Closed
magic-peach wants to merge 1 commit into
kubernetes-sigs:mainfrom
magic-peach:add-pure-helper-tests
Closed

magic-peach wants to merge 1 commit into
kubernetes-sigs:mainfrom
magic-peach:add-pure-helper-tests

Conversation

@magic-peach

Copy link
Copy Markdown

These pure helpers had zero direct test coverage. Covers repo extraction from normal and short module paths, version-suffix repo names, the all-digits check, and cycle classification against a test-only node set including the empty-set case.

Tested with go test ./..., go vet ./... and go build ./..., all pass.

These pure helpers had zero direct test coverage. Covers repo
extraction from normal and short module paths, version-suffix repo
names, the all-digits check, and cycle classification against a
test-only node set including the empty-set case.
@kubernetes-prow kubernetes-prow Bot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 20, 2026
@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: magic-peach
Once this PR has been reviewed and has the lgtm label, please assign rinkiyakedad for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 20, 2026
@skitt

skitt commented Sep 21, 2026

Copy link
Copy Markdown
Member

@kubernetes-prow kubernetes-prow Bot closed this Sep 21, 2026
@kubernetes-prow

Copy link
Copy Markdown

@skitt: Closed this PR.

Details

In response to this:

See https://kubernetes.slack.com/archives/C01672LSZL0/p1789992857325439

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants