Fix release failure after maven central plugin migration#4432
Fix release failure after maven central plugin migration#4432yue9944882 wants to merge 3 commits intokubernetes-client:masterfrom
Conversation
Signed-off-by: Min Jin <minkimzz@amazon.com>
Signed-off-by: Min Jin <minkimzz@amazon.com>
Signed-off-by: Min Jin <minkimzz@amazon.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yue9944882 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
size/M
|
Ref: #4239 |
| ./mvnw -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn -DlocalCheckout=true -Darguments=-DskipTests org.apache.maven.plugins:maven-release-plugin:perform | ||
| ./mvnw -s /home/runner/.m2/settings.xml -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn -DlocalCheckout=true -Darguments=-DskipTests org.apache.maven.plugins:maven-release-plugin:perform | ||
| curl -X POST \ | ||
| -H "Authorization: Bearer $(echo ${{ secrets.SNAPSHOT_UPLOAD_USER }}:${{ secrets.SNAPSHOT_UPLOAD_PASSWORD }} | base64 -w0)" \ |
There was a problem hiding this comment.
Is this going to dump our password into the logs for our github actions workflows? Is there another way to do this?
There was a problem hiding this comment.
# The tests are already executed in the prepare, skipping
./mvnw -s /home/runner/.m2/settings.xml -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn -DlocalCheckout=true -Darguments=-DskipTests org.apache.maven.plugins:maven-release-plugin:perform
curl -X POST \
-H "Authorization: *** ***:*** | base64 -w0)" \
https://ossrh-staging-api.central.sonatype.com/manual/upload/defaultRepository/io.kubernetes -v
git push https://***@github.com/kubernetes-client/java.git \
automated-release-25.0.0-legacy:automated-release-25.0.0-legacy
git push https://***@github.com/kubernetes-client/java.git v25.0.0-legacy
https://github.com/kubernetes-client/java/actions/runs/19683023331/job/56381525646
the workflow auto-redact the secrets in our workflow ^^^
There was a problem hiding this comment.
I really still don't love this, redaction should be a last resort, not an relied upon feature. There must be some way to do this without it being on the command line.
|
Looks good, but I'm worried that the current curl call is going to dump our auth info into the CI/CD logs. |
| ./mvnw -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn -DlocalCheckout=true -Darguments=-DskipTests org.apache.maven.plugins:maven-release-plugin:perform | ||
| ./mvnw -s /home/runner/.m2/settings.xml -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn -DlocalCheckout=true -Darguments=-DskipTests org.apache.maven.plugins:maven-release-plugin:perform | ||
| curl -X POST \ | ||
| -H "Authorization: Bearer $(echo ${{ secrets.SNAPSHOT_UPLOAD_USER }}:${{ secrets.SNAPSHOT_UPLOAD_PASSWORD }} | base64 -w0)" \ |
There was a problem hiding this comment.
I really still don't love this, redaction should be a last resort, not an relied upon feature. There must be some way to do this without it being on the command line.
| <!-- TODO: workaround until openapi stops generating a dependency on | ||
| the un-exported module: com.google.gson.internal.bind.util --> | ||
| <legacyMode>true</legacyMode> | ||
| <tags> |
There was a problem hiding this comment.
What does this do? Is this part of the TODO above also?
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
This PR adds API after maven release plugin run according to: