fix: grant publish workflow release permissions - #3
Conversation
|
Eric Greer (@integrii) Maintainer approval/merge requested for the release blocker. This PR is the existing commit |
|
Feasible and in scope: this workflow-only change adds the permissions required for GitHub release asset upload and PyPI trusted publishing. DCO passes; Build checks are queued. Reviewer, please review after CI completes. Maintainer approval remains required before merge. |
There was a problem hiding this comment.
Reviewed commit 5281813. The workflow permissions are correctly scoped for release asset upload and PyPI OIDC/token publishing; no code defects found in this diff.
Next steps: wait for the Build check to pass, then maintainer approval/merge. After merge, rerun the existing v0.1.0 publish workflow and verify kuberhealthy-client is available on PyPI.
|
Release status: no new tag or GitHub Release is needed. v0.1.0 remains the current release. After this workflow fix merges, configure PyPI trusted publishing (OIDC) or a valid token, then rerun failed workflow 33161389524. |
Signed-off-by: Kuberhealthy Coder <kuberhealthy-coder[bot]@users.noreply.github.com>
|
Security hardening update: commit |
|
Update: the PR now targets head |
There was a problem hiding this comment.
Reviewed latest head 1ae6e0d5b157a5720994e99aa9d9a7ded1722c1a. The workflow split, artifact handoff, and job-scoped contents: write/id-token: write permissions are appropriate; no defects found in this diff. Next steps: wait for both Build checks to pass, obtain maintainer approval/merge, then rerun the v0.1.0 publish workflow and verify PyPI availability.
Signed-off-by: Kuberhealthy Coder <kuberhealthy-coder[bot]@users.noreply.github.com>
|
Updated in commit
YAML and diff checks pass; adversarial review found no significant remaining findings. Maintainer review/merge is still required. Note: workflow run |
|
Update for head |
There was a problem hiding this comment.
Reviewed exact head e331761374c2de401452e492a3c5f12b94c30305. No findings. Build and PyPI jobs use permissions: {}; release asset upload alone has contents: write; token authentication correctly omits id-token: write; all action refs resolve to immutable commit SHAs; release assets depend on successful PyPI publishing. YAML parses successfully and DCO passes.\n\nNext steps: wait for both Build checks to pass, then obtain maintainer approval/merge. After merge, trigger a new release event or recovery path for v0.1.0 because run 33161389524 is tied to the pre-fix SHA, then verify kuberhealthy-client on PyPI.
There was a problem hiding this comment.
Rechecked exact head e331761374c2de401452e492a3c5f12b94c30305. Build and DCO checks pass; PR is CLEAN/MERGEABLE; no findings.
Next steps: obtain human maintainer approval/merge. After merge, trigger a new v0.1.0 release/recovery path because failed run 33161389524 is tied to the pre-fix SHA, then verify PyPI availability.
There was a problem hiding this comment.
Reviewed exact head e331761. Build and DCO checks pass; no findings. Recommendation: merge under the explicit maintainer authorization in the #kuberhealthy thread.
The publish workflow needs explicit permissions for GitHub release asset upload and PyPI trusted publishing.
This PR exposes existing commit
5281813ea2656f3174f6023e835cdd02fe1a7a57, which adds:contents: writeid-token: writeThis is required before rerunning failed workflow
33161389524. No release/tag changes are included.