Fix unreachable target expectation handling - #2
Merged
Merged
Conversation
![kuberhealthy-code-reviewer[bot]](https://avatars.githubusercontent.com/in/4015246?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No findings. The unreachable-target path now fails when the target connects successfully and passes only on dial failure, with focused regression coverage for both reachable and unreachable expectations.
Verified locally with CGO_ENABLED=0 go1.24.3 test ./...; GitHub build and DCO checks are also green.
Recommendation: ready for maintainer final review and merge.
Member
|
LGTM. Ship it. |
|
Released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CONNECTION_TARGET_UNREACHABLE=truebut the target is reachableDialContextso expected-unreachable dial timeouts are handled by the dial result instead of racing an outer timerAddresses kuberhealthy/kuberhealthy#1283.
Validation
PATH=/tmp/go1.24.3/bin:/usr/bin:/bin:$PATH go test ./...git diff --checkReview