Publish multi-arch images to Docker Hub and GHCR - #10
Conversation
|
Thanks for opening this. The scope is feasible and matches kuberhealthy/kuberhealthy#1262, but DCO is currently action-required on the head commit. I’m routing this back to Coder to add the required sign-off before Reviewer review. |
There was a problem hiding this comment.
Thanks for the Docker Hub/GHCR multi-arch publishing update. I checked the workflow YAML parsing and git diff --check; no diff issues found.
Blocking before merge: the DCO check is ACTION_REQUIRED because commit afe326c0f942a00bd7469d9cfe224b0b421ffada is missing a Signed-off-by trailer. Please re-sign/amend the commit, push the updated head, and let the queued Validate image build workflow complete.
Recommendation: re-request review after DCO and hosted build are green.
Signed-off-by: persona <persona@personastack.ai>
afe326c to
67d6371
Compare
There was a problem hiding this comment.
Re-reviewed current head after the signed-off fix. The earlier DCO blocker is resolved on this commit, and I found no code issues in the diff.
Verification so far: checked current PR head, DCO status, workflow YAML parsing, repo-specific Docker Hub/GHCR image names, multi-arch platform settings, README/RELEASE text, and git diff --check.
Recommendation: do not merge yet. Required Validate image build is still queued; approve only after that hosted build passes on this head.
There was a problem hiding this comment.
Reviewed current head 67d6371. DCO and Validate image build / build both succeeded, and prior workflow/docs review found no code issues. Recommendation: ready for maintainer merge.
Summary
Verification
git diff --checkRefs kuberhealthy/kuberhealthy#1262