Strip reserved authentication.kubernetes.io extras before impersonation#434
Merged
Conversation
Copying user.GetExtra() verbatim into the impersonation config also copies server-injected reserved extras (e.g. authentication.kubernetes.io/credential-id added for X509/SA auth on k8s >=1.30). Impersonating those needs a dedicated userextras RBAC verb that kube-ui-server does not hold, causing a forbidden error on EditorModel reads. These extras carry no authorization identity, so drop the authentication.kubernetes.io/ prefixed keys before impersonating. Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
EditorModelreads fail with:callerClientcopiesuser.GetExtra()verbatim into the impersonation config. On k8s >=1.30, the apiserver injects reserved extras (e.g.authentication.kubernetes.io/credential-idfor X509 / SA-token auth). Impersonating those requires a dedicateduserextras/...impersonate RBAC verb thatkube-ui-serverdoes not hold, so the request is rejected.Fix
Drop
authentication.kubernetes.io/-prefixed keys before building the impersonation config. These are server-injected and carry no authorization identity (RBAC binds on user/group), so stripping them does not change the impersonated client's effective permissions.ace.appscode.com/org-idand other extras are preserved.Note
kmodules.xyz/client-go/client/delegated.go::Impersonate(used bypkg/graph) has the same pattern and will need the same fix upstream + re-vendor.