Refactor the full controller#46
Merged
Merged
Conversation
Use the reconcile request context instead of context.TODO() in the pod finalizer CreateOrPatch and in terminate(). Guard against a nil annotations map before writing the deletion-initiator key, which could panic for pods created without annotations. Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
Move convContainer, findMount, and listVolumes out of the reconciler file and add newSidekickPod, which builds the sidekick Pod object for a given leader. Reconcile now delegates pod construction instead of inlining an 80-line object literal. No functional change. Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
Break the 200-line Reconcile body into podNeedsRecreate, deletePodAndResetStatus, syncExistingPod, and createSidekickPod. deletePodAndResetStatus deduplicates two identical delete-and-reset blocks. Remove an unreachable error branch after the pod Get (non- NotFound errors are already returned earlier) and a commented-out status write. Control flow, status updates, and requeue behavior are unchanged. Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
Rename single-letter closure and loop variables (po, c) to descriptive names, drop the Kubebuilder scaffold TODO from the Reconcile doc comment, and document the pod-name ordinal regex. Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.