Add vcd-lb-gc chart#492
Merged
Merged
Conversation
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
tamalsaha
force-pushed
the
add-vcd-lb-gc-chart
branch
from
c514a46 to
697f4c7
Compare
tamalsaha
force-pushed
the
add-vcd-lb-gc-chart
branch
from
697f4c7 to
0b86601
Compare
Add the vcd-lb-gc Helm chart and its values schema type. - apis/installer/v1alpha1: VcdLbGc/VcdLbGcList types describing the chart values, registered with the scheme (+ generated deepcopy) - charts/vcd-lb-gc: deployment, serviceaccount, cluster role/binding, leader-election role/binding, VCD credentials secret, NOTES, values.yaml - Generated values.openapiv3_schema.yaml and README via make gen The controller lives at https://github.com/kubeops/vcd-lb-gc. Signed-off-by: Tamal Saha <tamal@appscode.com>
tamalsaha
force-pushed
the
add-vcd-lb-gc-chart
branch
from
0b86601 to
060e89e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the Helm chart for kubeops/vcd-lb-gc — a controller that garbage-collects orphaned VMware Cloud Director load-balancer objects.
apis
apis/installer/v1alpha1/vcd_lb_gc_types.go:VcdLbGc/VcdLbGcList(VcdLbGcSpec) describing the chart values; reuses the sharedContainer/ServiceAccountSpectypes plus newVcdLbGcConfigandVcdLbGcCredentialsregister.go; deepcopy generated inzz_generated.deepcopy.gochart (
charts/vcd-lb-gc)deployment,serviceaccount,cluster-role+ binding, leader-electionrole+ binding, VCD credentialssecret(withvcd.existingSecretopt-out),NOTES.txt,_helpers.tplvalues.yaml,doc.yamlvalues.openapiv3_schema.yamlandREADME.mdgenerated viamake genhelm lint charts/vcd-lb-gcpasses (the SemVerV2 warning on the calver version matches every other chart here).Companion PR: kubeops/vcd-lb-gc#2 (removes the repo's raw
deploy/manifests in favor of this chart).Note: like some other charts, this does not include a
values.schema.json(nomake genstep produces it).