manager: keep OCM AddOn manager running until context cancelled#28
Merged
Conversation
addonManager.Start only launches the informers in background goroutines and returns nil immediately. With leader election disabled (the default for a local --kubeconfig run), the command runner returns that value directly, so the process exited as soon as Start returned instead of staying up. Block on ctx.Done() after Start so the manager keeps running until SIGTERM/SIGINT. Signed-off-by: Tamal Saha <tamal@appscode.com>
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
fargocd managerexits immediately instead of staying running:Root cause
addonManager.Start(ctx)from the addon-framework only launches itsinformers in background goroutines and returns
nilimmediately — it isnot a blocking call.
runManagerControllerreturned that value directly,and the cmdfactory runner does
return c.startFunc(...)when leaderelection is disabled (the default for a local
--kubeconfigrun). Withnothing left to keep the process alive, it exited cleanly the moment
Startreturned.(With leader election enabled, the same premature return would instead
trip the "controllers terminated prematurely" path and
os.Exit(1).)Fix
Block on
<-ctx.Done()afterStartsucceeds — the standard OCM addonpattern. The context is the signal-aware context wired by the cmdfactory,
so the manager now runs until SIGTERM/SIGINT.