credentials: add unit tests for secret validators#84
Merged
Conversation
pkg/credentials had zero tests. Add coverage for the four validXxxSecret helpers — most interestingly Cloudflare, whose token-vs-key+email branch logic is easy to break silently. Tests also lock in the current behavior of treating a present-but-empty token key as valid; refactors that change it will now have to either update the test or justify the change. Signed-off-by: Tamal Saha <tamal@appscode.com>
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`pkg/credentials` had no tests. Add coverage for the four `validXxxSecret` helpers — most interestingly Cloudflare, whose token-vs-key+email branching is easy to break silently. Locks in the current behavior of treating a present-but-empty token key as valid; refactors that change it will need to either update the test or justify the change.
Limited to the validator surface (no envtest controller test) — those need `config/crd/bases` wiring that doesn't exist in the repo yet and are better as a follow-up.
Test plan