api: activate kubebuilder Enum markers on Policy and Provider#81
Merged
Conversation
Both kubebuilder:validation:Enum lines were missing the leading '+', so controller-gen treated them as plain comments. The generated CRD yaml has 'type: string' with no enum constraint on either field — which is why an arbitrary spec.provider string makes it through to the reconciler today. Add the '+' and drop the spurious ':=' (the correct syntax is 'Enum=v1;v2;...'). After this, 'make manifests' will regenerate the CRD yaml with the enum constraint; that regeneration runs in Docker and is intentionally not bundled with this PR. Signed-off-by: Tamal Saha <tamal@appscode.com>
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both `kubebuilder:validation:Enum` lines on `Policy` and `Provider` were missing the leading `+`, so `controller-gen` treated them as plain comments. The generated CRD has `type: string` with no enum constraint on either field — which is why an arbitrary `spec.provider` string makes it past the API server today.
Add the `+` and drop the spurious `:=` (correct syntax is `Enum=v1;v2;...`).
Test plan