plan: base defaultConfig on externaldns.NewConfig#73
Merged
Conversation
The hand-rolled defaultConfig duplicated upstream's CLI defaults and
made every line of upstream's Config visible — including dozens of
explicit zero-value lines that added noise without adding meaning.
Replace it with newDefaultConfig(), which:
- starts from externaldns.NewConfig() so any new defaulted field
upstream adds in NewConfig flows in automatically;
- only assigns fields whose desired default differs from the Go zero
value (so the file shrinks substantially);
- retains the kingpin-flag defaults the operator still mimics, with a
comment flagging that those need to be tracked manually until we
can adopt the upstream binder directly.
Behavior is preserved: previously-explicit zero values are now implicit,
and the meaningful defaults (regex filters, owner ID, intervals, etc.)
are kept verbatim.
Signed-off-by: Tamal Saha <tamal@appscode.com>
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The hand-rolled `defaultConfig` duplicated upstream's CLI defaults and included dozens of explicit zero-value lines.
Replace it with `newDefaultConfig()` that:
Behavior preserved: previously-explicit zero values are now implicit; meaningful defaults (regex filters, owner ID, intervals, etc.) are kept verbatim.
Test plan