controller: clean up credential temp files on finalizer removal#69
Merged
Conversation
The AWS / Azure / Google credential setters write the secret material into /tmp/<ns>-<name>-credential with mode 0600. handleDeletion removed the finalizer but left the file behind, so a long-running operator pod that has churned through many ExternalDNS objects ended up holding every credential it has ever served. Add credentials.CleanupCredential and call it from handleDeletion before the finalizer is removed. The function is a no-op for providers that do not write a file (Cloudflare) and tolerates an already-deleted file. Signed-off-by: Tamal Saha <tamal@appscode.com>
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AWS / Azure / Google credential setters write secret material to `/tmp/--credential`. `handleDeletion` removed the finalizer but never removed the file, so a long-running operator pod accumulated every credential it ever served.
Add `credentials.CleanupCredential` and call it from `handleDeletion` before the finalizer is removed. No-op for providers that don't use a file (Cloudflare); tolerant of an already-deleted file.
Test plan