plan: configure global loggers once, not on every reconcile#66
Open
tamalsaha wants to merge 1 commit into
Open
plan: configure global loggers once, not on every reconcile#66tamalsaha wants to merge 1 commit into
tamalsaha wants to merge 1 commit into
Conversation
SetDNSRecords used to call annotations.SetAnnotationPrefix() and configureLogger() on every reconcile. Both mutate process-wide state in external-dns / logrus. Two ExternalDNS resources with different log settings (or, in the future, different annotation prefixes) would race and last-writer-win. - Drop the annotations.SetAnnotationPrefix call: the operator never reads an annotation-prefix from the CR; the value is always the upstream default already wired in defaultConfig, so calling the setter every reconcile is dead work that also pokes a global. - Guard configureLogger with sync.Once so the first reconcile fixes the log level/format and subsequent reconciles cannot flip them. Signed-off-by: Tamal Saha <tamal@appscode.com>
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SetDNSRecordsmutated process-wide state on every reconcile:annotations.SetAnnotationPrefix(...)— but the operator never reads a custom prefix from the CR. The setter was always being called with the upstream default. Removed.configureLogger(...)— re-set logrus level/format on every call. TwoExternalDNSresources with different log settings would race. Guarded withsync.Once.Test plan
go build ./...