Skip to content

chore: pin all github actions to their shasum#983

Open
christian-heusel wants to merge 1 commit intokubeflow:notebooks-v1from
christian-heusel:chore/notebooks-v1-pin-all-actions-to-shasum
Open

chore: pin all github actions to their shasum#983
christian-heusel wants to merge 1 commit intokubeflow:notebooks-v1from
christian-heusel:chore/notebooks-v1-pin-all-actions-to-shasum

Conversation

@christian-heusel
Copy link

This way we're not so easy to be targeted by supply chain attacks such as the trivy incident that motivated this initially.

The changes were generated via a script that I wrote to do this, see the second link below.

Link: https://www.openwall.com/lists/oss-security/2026/03/21/1
Link: https://github.com/christian-heusel/dotfiles/blob/main/misc/scripts/pin-github-actions.sh

@github-project-automation github-project-automation bot moved this to Needs Triage in Kubeflow Notebooks Mar 21, 2026
@google-oss-prow google-oss-prow bot added area/ci area - related to ci size/L labels Mar 21, 2026
@google-oss-prow google-oss-prow bot added the area/v1 area - version - kubeflow notebooks v1 label Mar 21, 2026
@christian-heusel
Copy link
Author

/ok-to-test

Copy link
Contributor

@andyatmiami andyatmiami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 nit - 1 issue the def needs resolved - everything else looks great (and it was pre-existing land mines that were the only reason your script got tripped up)

thanks!

will lgtm + approve once you have time to push fixes

This way we're not so easy to be targeted by supply chain attacks such
as the trivy incident that motivated this initially.

The changes were generated via a script that I wrote to do this, see the
second link below.

Link: https://www.openwall.com/lists/oss-security/2026/03/21/1
Link: https://github.com/christian-heusel/dotfiles/blob/main/misc/scripts/pin-github-actions.sh
Co-authored-by: Andy Stoneberg <andyatmiami@users.noreply.github.com>
Signed-off-by: Christian Heusel <christian@heusel.eu>
@christian-heusel christian-heusel force-pushed the chore/notebooks-v1-pin-all-actions-to-shasum branch from 582a39c to 245652b Compare March 22, 2026 10:41
Copy link
Contributor

@andyatmiami andyatmiami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks again @christian-heusel for being so responsive here to improve our security posture 💯

@google-oss-prow google-oss-prow bot added the lgtm label Mar 22, 2026
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andyatmiami
Once this PR has been reviewed and has the lgtm label, please assign thesuperzapper for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci area - related to ci area/v1 area - version - kubeflow notebooks v1 lgtm ok-to-test size/L

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

2 participants