fix: make deploy supports release branch#981
Open
andyatmiami wants to merge 1 commit intokubeflow:notebooks-v2from
Open
fix: make deploy supports release branch#981andyatmiami wants to merge 1 commit intokubeflow:notebooks-v2from
andyatmiami wants to merge 1 commit intokubeflow:notebooks-v2from
Conversation
The deploy target's `kustomize edit set image` was never actually overriding the base kustomization's image tag. This was masked on non-release branches because the base newTag (latest) happened to match the hardcoded test image tag. On release branches, the base newTag changes to the release version, exposing the mismatch and causing e2e test pods to stay Pending (image not found in Kind). Fix by: - Copying kustomize to .output/ so edits don't modify tracked files - Matching both short name and registry-prefixed name to ensure the override works regardless of base kustomization state Extracted from kubeflow#763. Signed-off-by: Andy Stoneberg <astonebe@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
google-oss-prow
bot
added
area/controller
Contributor
Author
|
/ok-to-test |
christian-heusel
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deploy target's
kustomize edit set imagewas never actually overriding the base kustomization's image tag. This was masked on non-release branches because the base newTag (latest) happened to match the hardcoded test image tag. On release branches, the base newTag changes to the release version, exposing the mismatch and causing e2e test pods to stay Pending (image not found in Kind).Fix by:
Extracted from #763.