refactor: add new lint for omitempty on slice fields and apply it treewide #980
Draft
christian-heusel wants to merge 2 commits intokubeflow:notebooks-v2from
Draft
Conversation
Adds a standalone go/analysis linter (tools/linters) that enforces omitempty on all slice fields with a json struct tag. Integrates it into the lint target of both the backend and controller Makefiles. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Christian Heusel <christian@heusel.eu>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
google-oss-prow
bot
added
area/controller
Fixes all violations reported by the new linter, adding the omitempty tag to slice fields across all backend models and controller API types. Signed-off-by: Christian Heusel <christian@heusel.eu>
christian-heusel
force-pushed
the
feat/build-go-lint-tool-omitempty
branch
from
ab11414 to
649028b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea on this was brought up by @thesuperzapper regarding the discussion around #976.
Alternatively we could aim to use the
nilas empty array change from the upcoming from the jsonv2 proposal in golang:golang/go#63397 / https://pkg.go.dev/encoding/json/v2
This will most likely break the frontend and require adjustments in the tests, so this is not to be merged yet.
Would be nice to get some intput on this from @ederign for the frontend side of things as per @andyatmiami's tip.