feat: add display name support for workspaces#940
Open
andyatmiami wants to merge 1 commit intokubeflow:notebooks-v2from
Open
feat: add display name support for workspaces#940andyatmiami wants to merge 1 commit intokubeflow:notebooks-v2from
andyatmiami wants to merge 1 commit intokubeflow:notebooks-v2from
Conversation
Contributor
Author
|
/hold want to rework this to expose DisplayName on the CRD since we control the CRD |
andyatmiami
force-pushed
the
chore/workspace-display-name
branch
from
e5c0721 to
18373d6
Compare
google-oss-prow
bot
added
the
area/controller
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
andyatmiami
force-pushed
the
chore/workspace-display-name
branch
from
18373d6 to
352ac4b
Compare
Contributor
Author
|
/ok-to-test |
Contributor
Author
|
/unhold
|
andyatmiami
force-pushed
the
chore/workspace-display-name
branch
from
352ac4b to
3717ece
Compare
Add `displayName` as an optional field on `WorkspaceSpec`, following the pattern established by WorkspaceKind. This allows users to set a human-readable name for their workspaces in the UI. Changes: - Add `DisplayName` field to `WorkspaceSpec` CRD type (max 128 chars) - Update backend models (`WorkspaceListItem`, `WorkspaceCreate`, `WorkspaceUpdate`) to read/write from the new spec field - Mark `displayName` as optional in the API contract (`omitempty`) - Add handler test coverage for display name round-trip - Regenerate CRD manifests and Swagger docs Signed-off-by: Andy Stoneberg <astonebe@redhat.com>
andyatmiami
force-pushed
the
chore/workspace-display-name
branch
from
3717ece to
9558f47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ NO GH ISSUE
Add
displayNameas an optional field onWorkspaceSpec, followingthe pattern established by WorkspaceKind. This allows users to set a
human-readable name for their workspaces in the UI.
Changes:
DisplayNamefield toWorkspaceSpecCRD type (max 128 chars)WorkspaceListItem,WorkspaceCreate,WorkspaceUpdate) to read/write from the new spec fielddisplayNameas optional in the API contract (omitempty)