feat: Add secrets management page#920
feat: Add secrets management page#920Snehadas2005 wants to merge 2 commits intokubeflow:notebooks-v2from
Conversation
… functionality. Signed-off-by: Sneha Das <154408198+Snehadas2005@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @andyatmiami, |
|
@Snehadas2005 - I was hoping we could have talked before you raised this PR - as I'm not clear how we could properly implement this on the frontend without considering backend API changes. For
For this "global" So to just set expectations - and I have no looked at the code yet - I find it hard to think we could get this PR merged in its current state. It would be useful for all involved if you could gather some screencaps and/or put a short recording (no audio needed) on this PR to see how this looks/flows though! thanks! |
|
Hi @andyatmiami, Thanks for your feedback. The current implementation restricts secrets to the selected Looking forward to your thoughts!
|
… functionality. Signed-off-by: Sneha Das <154408198+Snehadas2005@users.noreply.github.com>




Description:
This PR introduces a dedicated Secrets Management page for Notebooks 2.0, enabling users to manage Kubernetes secrets directly from the UI. It fulfills the user story requirements for managing secrets within a selected namespace.
Changes:
/secrets) accessible from the main navigation.useSecretsByNamespacehook to fetch and manage secrets data.SecretsCreateModalandSecretsViewPopoverfor a consistent UI/UX.AppRoutes.tsxandroutes.ts.Related Issues:
Testing:
npm run test:lint) — all passed.