Skip to content

feat: Add secrets management page#920

Open
Snehadas2005 wants to merge 2 commits intokubeflow:notebooks-v2from
Snehadas2005:temp2
Open

feat: Add secrets management page#920
Snehadas2005 wants to merge 2 commits intokubeflow:notebooks-v2from
Snehadas2005:temp2

Conversation

@Snehadas2005
Copy link

Description:
This PR introduces a dedicated Secrets Management page for Notebooks 2.0, enabling users to manage Kubernetes secrets directly from the UI. It fulfills the user story requirements for managing secrets within a selected namespace.

Changes:

  • Added a new Secrets page (/secrets) accessible from the main navigation.
  • Implemented useSecretsByNamespace hook to fetch and manage secrets data.
  • Added functionality to:
    • List all secrets in the current namespace.
    • Create new Opaque secrets with key/value pairs.
    • Edit existing mutable secrets.
    • Delete secrets.
  • Integrated SecretsCreateModal and SecretsViewPopover for a consistent UI/UX.
  • Updated routing configuration in AppRoutes.tsx and routes.ts.

Related Issues:

Testing:

  • Verified that the Secrets menu item appears in navigation.
  • Confirmed secrets list loads correctly for the selected namespace.
  • Tested creating, editing, and deleting secrets.
  • Confirmed immutable secrets cannot be edited.
  • Ran lint checks (npm run test:lint) — all passed.

… functionality.

Signed-off-by: Sneha Das <154408198+Snehadas2005@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this to Needs Triage in Kubeflow Notebooks Feb 19, 2026
@google-oss-prow google-oss-prow bot added the area/frontend area - related to frontend components label Feb 19, 2026
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ederign for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added area/v2 area - version - kubeflow notebooks v2 size/L labels Feb 19, 2026
@Snehadas2005
Copy link
Author

Hi @andyatmiami,
I have completed implementing the Secrets management page for notebooks-v2. Whenever you get a chance, could you please review this PR? I would really appreciate your feedback.
Thank you!

@andyatmiami
Copy link
Contributor

@Snehadas2005 - I was hoping we could have talked before you raised this PR - as I'm not clear how we could properly implement this on the frontend without considering backend API changes.

For notebooks-v2 - we have 2 key "personas" we are interested in:

  • Bella (data scientist)
  • Joel (MLOps / Platform admin)

For this "global" Secrets page - I would imagine Joel is interested in seeing secrets across the cluster (i.e. namespace-less view) - but that type of query is not inherently supported in the API (yet)..

So to just set expectations - and I have no looked at the code yet - I find it hard to think we could get this PR merged in its current state.

It would be useful for all involved if you could gather some screencaps and/or put a short recording (no audio needed) on this PR to see how this looks/flows though!

thanks!

@Snehadas2005
Copy link
Author

Hi @andyatmiami,

Thanks for your feedback. The current implementation restricts secrets to the selected workspace/namespace, as the backend API doesn’t support a cluster-wide view. It aligns with Bella’s persona (namespace-scoped usage). I can adjust the approach if we want to design for Joel’s persona or consider backend API changes.

Looking forward to your thoughts!

image image image image

… functionality.

Signed-off-by: Sneha Das <154408198+Snehadas2005@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/frontend area - related to frontend components area/v2 area - version - kubeflow notebooks v2 size/L

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

2 participants