refactor: make external-dns values provider-aware#391
Merged
Conversation
tuunit
requested changes
Jun 16, 2026
7050261 to
f8fc069
Compare
15 tasks
tuunit
requested changes
Jun 18, 2026
4385102 to
049169d
Compare
tuunit
requested changes
Jun 19, 2026
049169d to
c7667ed
Compare
c7667ed to
efcd36e
Compare
tuunit
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Prepares the first small split from #370 by refactoring the built-in ExternalDNS Helm values for provider-specific configuration.
The existing Stackit-specific ExternalDNS settings are now rendered conditionally from
terraform.provider, while provider-independent values remain shared. This establishes the supported pattern for adding further provider-specific ExternalDNS configuration without duplicating complete Helm values files.Additional changes made while preparing this split and addressing review feedback:
terraform/providers/<provider>/; Helm provider behavior stays in shared values templates or charts.TerraformProvidertype and centralize supported Terraform provider validation.terraform.provider: noneas the default to support clusters without Terraform-managed infrastructure.kubara generate.kubara generate --terraformstrict and require a supported Terraform provider.VolumeSnapshotClasswhen Terraform is disabled.kubara init --overwrite.🧩 Type of change
No intended breaking changes to supported behavior. Existing Stackit ExternalDNS values are preserved when
terraform.provider: stackitis configured.Clusters without Terraform config, or with
terraform.provider: none, can now use the defaultkubara generateflow without forcing--helm.🧪 Testing
Ran locally:
cd src && make testcd src && go test ./internal/workflow ./cmd ./internal/config ./internal/render -count=1make docs-validategit diff --check🔗 Related Issues / Tickets
✅ Checklist
📎 Additional Context (optional)
This PR intentionally covers the ExternalDNS values preparation plus the provider handling needed to make
terraform.provider: nonea valid no-Terraform state.It does not include T Cloud Public provider registration, OpenBao integration, Terraform modules, or the remaining provider-specific Helm changes from #370.