feat: support repository auth modes in ExternalSecret helper#389
Open
Matthiator wants to merge 2 commits into
Open
feat: support repository auth modes in ExternalSecret helper#389Matthiator wants to merge 2 commits into
Matthiator wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review order: This PR is stacked on #388. Please review and merge #388 first; this PR should be reviewed as the follow-up diff on top of that branch.
📝 Summary
Adds authMode-aware rendering to the Argo CD repository ExternalSecret helper so additional app repositories can use HTTPS, SSH deploy key, or GitHub App credentials.
HTTPS remains the default behavior, so existing
remoteRef+ PAT/password values keep rendering the same repository Secret fields. The Argo CD app repository documentation now includes vault andvalues.yamlexamples for all three modes.🧩 Type of change
🧪 Testing
Validated locally with:
cd src && make testmake docs-buildgit diff --checkhelm dependency build /tmp/kubara-repo-helper-charthelm templatefor HTTPS, SSH, and GitHub App repository exampleshelm templatefailure check for missing GitHub App ID🔗 Related Issues / Tickets
Related to #246
Stacked on #388.
✅ Checklist
📎 Additional Context (optional)
This follows the bootstrap repository auth-mode work by extending the same credential modes to the reusable ExternalSecret helper for additional Argo CD app repositories.