feat(picker): forget the selected Project with ctrl+d (#69) - #84
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
forgetonctrl+d. It asksforget <name>? y/non the footer;ycalls the Store'sForget, drops the row and keeps the cursor at the same index (the row below, or the one above at the end of the list). Any other key cancels and is consumed, soy/nnever reach the filter.Forgeterror shows red on the footer and keeps the row.Action.Copy boolis generalised toAction.Internal string(copy,forget): a Picker-side job with norun, cleared by a userrunorjump, rebindable and unbindable like any Action.picker.Options.Forgetis wired tostore.Forgetinjump.Resolve; the vim help overlay and README describe it.Verification
gofmt -l .empty,go vet ./...clean,golangci-lint run ./...0 issues,go test ./...passes except the known local-only fish cases ofTestScriptExecution; the binary builds.Closes #69