feat(picker): key-hint footer and vim ? overlay - #82
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #67. Part of #61.
What changed
enterfirst, the rest in order, unbound Actions left out. Whole hints that do not fit are dropped behind a….action.Mergenow takes the table order and returns the user's own Actions inconfig.tomlorder, followed by the built-ins (it used to put built-ins first, then user Actions sorted by name).configreads that order from the raw[actions.*]headers.messageLinehelper next to the hints.?opens an overlay of every key (navigation and Actions), and?,escorqclose it. While it is open other keys do nothing, ctrl+c still cancels. The footer shows? helpin vim list focus. An Action bound to?keeps the key. The default key map has no overlay.[picker] hints(default true) in config;falsehides the hints, leaving the match count and messages.config.example.tomldoes not exist yet, so it is not updated.Verification
gofmt -l .empty,go vet ./...clean,golangci-lint run ./...0 issues, binary builds, no file over 300 lines.go test ./...passes except the known local-only fish cases ofTestScriptExecution.hints = false, the overlay opening and closing in vim mode, only in list focus, fitting heights 3-40; config default/parse/type error; action order.