feat(action): built-in remote Action opens the git remote on ctrl+g (#65) - #80
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
git.WebURLrewrites a remote URL to the repo's https home page (scp-style,ssh://with/without port,git://, https with/without.git, GitLab subgroups, credentials stripped; local paths are an error).git.RemoteURL(ctx, dir)picksorigin, else the first remote, and returnsgit.ErrNotRepo/git.ErrNoRemote.{remote}in an Action'sRunexpands (shell-quoted) to that URL.action.Commandnow returns(*exec.Cmd, error)and fails when{remote}can't be resolved, soStart/Runreturn the error and the Picker showsremote: no git remoteon its footer and stays open. Nothing is looked up whenRunhas no{remote}.remoteAction:ctrl+g,<opener> {remote}, detached.[actions.remote] keyandrunoverride it as for any built-in.{remote}.Verification
gofmt clean,
go vet,golangci-lint run ./...(0 issues),go test ./...(only the known local fishTestScriptExecutionfailures), binary builds, no file over 300 lines. Table tests for the URL rewrites; real-repo tests for origin/first-remote/no-remote/not-a-repo; Picker footer test.Closes #65