Skip to content

feat(picker): Enter is the remappable jump Action (#63) - #77

Merged
hammadmajid merged 4 commits into
mainfrom
feat/63-jump-action
Oct 1, 2026
Merged

hammadmajid merged 4 commits into
mainfrom
feat/63-jump-action

Conversation

@hammadmajid

Copy link
Copy Markdown
Contributor

What changed

  • internal/action: register the built-in jump Action (key = "enter", jump = true, no run).
  • internal/picker/update.go: delete the three hard-coded enter cases and choose(). Enter now dispatches through the Action map like any other key, in the default key map, the vim list focus and the vim filter focus.
  • Docs: README (key tables, remapping Enter), CONTEXT.md, and the Choice/ChosenAction comments.

Behaviour notes

Verification

  • gofmt -l . empty, go vet ./... clean, go test ./... passes except the known fish cases of TestScriptExecution.
  • New tests: built-in jump on enter; merge with jump moved/unbound and enter given to another Action; picker Enter Jumps in default, vim list and vim filter focus; unbound enter does nothing; remapped enter runs the other Action and jump Jumps on its new key.
  • Built the binary and ran it with a temporary XDG_CONFIG_HOME: configs moving jump and giving enter to code, unbinding jump, and no config all load and reach the Picker (which then needs a TTY); code on enter with jump untouched fails with the line-numbered error actions.code: key: "enter" is already bound to "jump".

Closes #63

@hammadmajid
hammadmajid merged commit 1359178 into main Oct 1, 2026
2 of 3 checks passed
@hammadmajid
hammadmajid deleted the feat/63-jump-action branch October 1, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(picker): Enter is the remappable jump Action

1 participant