feat(picker): Enter is the remappable jump Action (#63) - #77
Merged
Merged
Conversation
This was referenced Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
internal/action: register the built-injumpAction (key = "enter",jump = true, norun).internal/picker/update.go: delete the three hard-codedentercases andchoose(). Enter now dispatches through the Action map like any other key, in the default key map, the vim list focus and the vim filter focus.Choice/ChosenActioncomments.Behaviour notes
jumpcan be moved ([actions.jump] key = "alt+enter") or unbound (key = ""). Another Action can then takeenter.enterfor another Action whilejumpstill holds it is the existing duplicate-key error from feat: Actions — run a command on the selected Project with a key #62, not an automatic unbinding. The README says to move or unbindjumpfirst.enter jump; feat(picker): key-hint footer and vim ? overlay #67 makes them follow the bindings.config.example.tomldoes not exist yet (feat(cli): example config in releases and cdd config init/path/edit #70), so the keys are not added there.Verification
gofmt -l .empty,go vet ./...clean,go test ./...passes except the known fish cases ofTestScriptExecution.jumpon enter; merge withjumpmoved/unbound and enter given to another Action; picker Enter Jumps in default, vim list and vim filter focus; unbound enter does nothing; remapped enter runs the other Action andjumpJumps on its new key.XDG_CONFIG_HOME: configs movingjumpand givingentertocode, unbindingjump, and no config all load and reach the Picker (which then needs a TTY);codeonenterwithjumpuntouched fails with the line-numbered erroractions.code: key: "enter" is already bound to "jump".Closes #63