Skip to content

Improve guide style - #188

Merged
robobario merged 1 commit into
kroxylicious:mainfrom
robobario:guide-css
Aug 14, 2025
Merged

Improve guide style#188
robobario merged 1 commit into
kroxylicious:mainfrom
robobario:guide-css

Conversation

@robobario

Copy link
Copy Markdown
Member

Aligns it more with the standalone asciidoc style, which has much nicer margins/padding and a single pixel top border for main sections, more padding on the codeblocks.

Adds a class to the top div surrounding the content so we can specifically target CSS to the guide content.

Before

Screenshot From 2025-08-14 16-44-03

After

Screenshot From 2025-08-14 16-43-29

Aligns it more with the standalone asciidoc style, which has much nicer
margins/padding and a single pixel top border for main sections

Signed-off-by: Robert Young <robertyoungnz@gmail.com>
@robobario

robobario commented Aug 14, 2025

Copy link
Copy Markdown
Member Author

The proxy quick start also includes some horizontal rules which I think we should drop in favour of styling the sections with css as there are now too many horizontal lines in that one guide.

@SamBarker SamBarker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k-wall

k-wall commented Aug 14, 2025

Copy link
Copy Markdown
Member

I've got a really poor eye for this kind of thing, but LGTM!

@robobario
robobario merged commit 14db103 into kroxylicious:main Aug 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants