Add CI to check that we can build the production site - #167
Merged
Conversation
SamBarker
approved these changes
Jul 21, 2025
SamBarker
left a comment
SamBarker
left a comment
Member
There was a problem hiding this comment.
Probably worth addressing the GHA warnings, but I think this is a very useful addition.
k-wall
approved these changes
Jul 21, 2025
Signed-off-by: Robert Young <robeyoun@redhat.com>
1. deprecated env var declaration style 2. CMD syntax recommended to use JSON args Signed-off-by: Robert Young <robertyoungnz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a separate workflow for PR CI, just checking we can build the site in production mode. We might need an accompanying change in the settings to require the checks to succeed before users can merge PRs.
The workflow is similar to the automation that deploys the website to GitHub Pages, but I made it a separate workflow as I'm envisaging adding specializations here. Like if there is any linting or simple tests we want to execute against the built site HTML we could do them in this workflow without riddling the prod deploy workflow with conditionals.