Open
Conversation
Wire up the parser, binder, and executor for DROP TRIGGER so it actually removes triggers from the catalog instead of throwing "not yet supported". - Parser: transform PG_OBJECT_TRIGGER into ExtraDropTriggerInfo with the base table reference (supports unqualified, schema-qualified, and catalog-qualified table names). - Binder: resolve the table, stamp catalog/schema onto DropInfo, and register the catalog modification. IF EXISTS guards only the trigger, not the table (PostgreSQL-compatible). - Executor: look up the table, call DuckTableEntry::DropTrigger, and respect IF EXISTS semantics. - Tests: functional tests (including catalog-qualified tables), parse-error tests, and WAL replay test. Made-with: Cursor
krleonid
force-pushed
the
feature/drop-trigger
branch
from
8861e2d to
9e57c68
Compare
- Add drop_trigger.test and drop_trigger_wal.test to skip lists in force_storage.json and verify_fetch_row.json (triggers require v2.0.0 storage, matching the existing create_trigger skip entries). - Fail loudly in ReplayDropTrigger when the WAL entry has an empty table name instead of silently skipping the drop. Made-with: Cursor
Triggers require v2.0.0 storage, matching the existing create_trigger skip entries in these configs. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire up the parser, binder, and executor for DROP TRIGGER so it actually removes triggers from the catalog instead of throwing "not yet supported".
Made-with: Cursor