finally nested embeds are working properly#5
Open
caefer wants to merge 8 commits intokriswallsmith:masterfrom
Open
finally nested embeds are working properly#5caefer wants to merge 8 commits intokriswallsmith:masterfrom
caefer wants to merge 8 commits intokriswallsmith:masterfrom
Conversation
* added fromArray() to pass existing values to fresh object * added myself as second @author
…ow deletion of nested dyn embeds
Contributor
Author
|
the last two commits now allow the deletion of dyn ambeds as well. finally all my tests run smoothly |
…ctrine_Relation::getAlias()
…t on an embedded form then the recurion did not start
Contributor
Author
|
This last one was reported by a guy called Paolo. See http://pastebin.com/Kv3ww8hx for details. |
Owner
|
Sorry I've been slow to get to this. I haven't forgotten. |
Contributor
Author
|
hey kris, I know I must be annoying and I understand that there are other things on your mind right now but this is important if we don't want to have split versions which I certainly don't. The pastebin link is still active and demonstrates the problem my fixes solve. cheers! |
…dual records/forms. But as they are executed for each record we need to filter for the correct ones.
…est to avoid incorrect validation errors
Contributor
Author
|
the last change is described in detail here: http://bit.ly/f3TioR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
after another hour of debugging I found that filterValues() needed to be recursive after all as the forms were structured correctly but the values were not (they were ignored completely but on the first level of nesting).
I also found a bug when creating fresh objects. They were not populated with the values from the form.
and because of all that I added myself as another @author if you don't mind. ;)