Let the opinion card's header wrap instead of splitting in two - #49
Merged
Merged
Conversation
On a phone the heading and the "unchanged since last time" badge shared one line and both broke inside themselves, so the card opened with two ragged two-line blocks side by side. Reproduced at 390px before changing anything, and looked at again afterwards rather than assumed. The row wraps now, so the badge takes its own line, and it does not break inside itself when it gets there. On a wide screen it still sits beside the heading — checked, same line, one line each — because wrapping only does something when there is not room. I caused this: the card said "Kvasir's opinion" until yesterday, and "What Mimir makes of this" is half as long again. A rename is a layout change and I did not treat it as one. The icon in that card was still U+1F71B, from the Alchemical Symbols block whose font coverage is thin enough to render an empty box. I replaced the same glyph in the navigation yesterday and missed this copy; it is now the diamond the nav uses. That leaves the logo as the last one in that block, which is on hold by request. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
kristianwind
force-pushed
the
opinion-header
branch
from
September 2, 2026 12:21
75fb4b5 to
90ab6fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a phone the heading and the "unchanged since last time" badge shared one line and both broke inside themselves, so the card opened with two ragged two-line blocks side by side.
Reproduced at 390px before changing anything, and looked at again afterwards rather than assumed:
whitespace-nowrapkeeps it one line when it gets thereI caused this. The card said "Kvasir's opinion" until yesterday; "What Mimir makes of this" is half as long again. A rename is a layout change and I did not treat it as one.
One thing I missed yesterday
The icon in that card was still
🜛(U+1F71B), from the Alchemical Symbols block whose font coverage is thin enough to render an empty box on Android. I replaced the same glyph in the navigation yesterday and missed this copy. It is now◈, the one the nav uses.That leaves the logo
🜁as the last glyph in that block — on hold by request.🤖 Generated with Claude Code