Do not publish a release whose image never arrived - #44
Merged
Merged
Conversation
v0.5.1 published every binary and checksums.txt while its image job was still running — 56 minutes against a normal 7 to 11, on the arm64 half under QEMU, two tag builds having started six minutes apart and shared the same gha cache. So the release existed and the image did not. The self-updater reads GitHub releases and would offer v0.5.1 to a self-hoster; the panel pulls :latest and got v0.5.0. Hosted and self-hosted diverge exactly there, and ending that divergence is why this file was rewritten in the first place. binaries now needs the image as well as the tests. Either both artefacts exist or neither does, and a stuck build leaves nothing half-published behind it. The gating still holds where it should: image is skipped on Gitea and on pull requests, and a skipped dependency skips its dependents — which is the wanted behaviour, since binaries already refuse to publish anywhere but GitHub on a tag. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.5.1published every binary andchecksums.txtwhile its image job was still running — 56 minutes against a normal 7–11:Two tag builds started six minutes apart and shared the same
type=ghacache; tags are deliberately not cancelled byconcurrency, so both ran.The result was the state this file was rewritten to prevent: the release existed and the image did not. The self-updater reads GitHub releases and would offer v0.5.1 to a self-hoster, while the panel pulls
:latestand got v0.5.0.binariesnow needsimageas well astest. Either both artefacts exist or neither does, and a stuck build leaves nothing half-published behind it.Gating still holds:
imageis skipped on Gitea and on pull requests, and a skipped dependency skips its dependents — which is the wanted behaviour, sincebinariesalready refuses to publish anywhere but GitHub on a tag.🤖 Generated with Claude Code