Conversation
|
Hello Professor, I know it says there is a duplication issue, this is because the code is very much based on plannings original code. Can you please excuse this. |
|
|
Hello Professor, I handled the duplicate code issues, I believe the code passes all the sonarcloud analysis tests. Can you take a look once and approve Professor? |
krishauser
left a comment
There was a problem hiding this comment.
There is no plan or justification for how this fits in with the other control components, when it is triggered, etc. PR not approved.
|
I want to clarify that the committed code is independent of controls PR, as it was originally developed for integration with the planning and parking teams. And please let me know if there are any other details I can provide for this PR. |



Hello Professor,
I have updated my other branch (creep-parking-planning) to resolve the issues. These were not issues with my file, as there were other integration changes from parking and planning. I hope the code can be resolved through that PR now. I just wanted to make sure the code gets approved so I decided to create this branch.
The only difference with this code and s2025 is the addition of my creeping planner.
The code I have included is in Gemstack/onboard/planning/creep_planning.py
This should resolve the issues.